search

embulk / embulk-base-restclient

Base class library for Embulk plugins to access RESTful services
https://www.embulk.org/
Apache License 2.0
6 stars 7 forks source link

Make |*ValueImporter| to throw Exceptions which are easier to investigate. #53

Closed dmikurube closed 7 years ago

dmikurube commented 7 years ago

@muga Making ValueImporter classes to show the column name where the ValueImporter fails.

One additional idea is to include the value in the message. It may be, however, security-incompliant because it prints customer's data into logs. Can I have your thoughts?

muga commented 7 years ago

@dmikurube LGTM.

One additional idea is to include the value in the message. It may be, however, security-incompliant because it prints customer's data into logs.

Agree. It's better that users could select print invalid records or not. I believe that this topic will be cared on https://github.com/embulk/embulk/issues/27

dmikurube commented 7 years ago

Thanks. Got it we have the topic under embulk/embulk. :)

dmikurube commented 7 years ago

Merged, and going to release v0.2.2!