Split out embulk-util-retryhelper-jaxrs.

dmikurube commented 7 years ago

@muga @sakama Can you have a look at this change?

It's a kind of big change. The main goal is to make the base library independent from JAX-RS specs.

Creating a HTTP client instance is 100% up to the plugin in ingestServiceData.
RetryHelper still exists, but out of the base library. JAXRSRetryHelper is now totally an independent helper library.
Only the JAX-RS RetryHelper exists atm, but other RetryHelper can be implemented like that such as JettyClientRetryHelper.

Seeing embulk-input-example may help understanding what happens. retryHelper is not given to ingestServiceData, but created in ingestServiceData by itself. https://github.com/embulk/embulk-base-restclient/compare/split-out-embulk-util-retryhelper-jaxrs?expand=1#diff-a6e536adc72626df2de1a8210d0cf618

muga commented 7 years ago

Looks good to me.

@sakama If you can, please try to use it on your local before this PR is merged into master?

sakama commented 7 years ago

If you can, please try to use it on your local before this PR is merged into master?

@muga @dmikurube OK. I'll try and send a report within a day.

sakama commented 7 years ago

LGTM My environment needs JettyClient. This implementation seems to works fine when other feature for Jetty Client is supported.

I'll try after above one is supported and will send PR when something go wrong.

dmikurube commented 7 years ago

Thanks. Merging this at first.

embulk / embulk-base-restclient