embulk / embulk-filter-column

A filter plugin for Embulk to filter out columns
Apache License 2.0
44 stars 10 forks source link

Build it with the "org.embulk.embulk-plugins" Gradle plugin #23

Closed dmikurube closed 3 years ago

dmikurube commented 4 years ago

Hi @sonots,

Thanks for using/contributing to Embulk. As we discussed in the developers' meeting, we're changing some of Embulk API/SPI. At first as a preparation for those changes, let me send this PR to build this Embulk plugin with the Gradle plugin org.embulk.embulk-plugins.

One request is to set your own Maven group name here. (E.g. io.github.sonots)

group = ""  // TODO: Fill out an appropriate group.

org.embulk.* is only for github.com/embulk.


Along with that,

It would required Embulk 0.9.14+ due to Exec.getLogger changes. But it's a year ago. I believe it would be acceptable.

dmikurube commented 4 years ago

Thanks!

An immediate release is not needed, but better to have soon.

This PR includes some reactions for deprecation (Exec.getLogger), and I think will have some more reactions for deprecation. Releasing a new version after them would be nice.