search

embulk / embulk-filter-column

A filter plugin for Embulk to filter out columns
Apache License 2.0
44 stars 10 forks source link

OutputPlugin is not closed #8

Closed hito4t closed 8 years ago

hito4t commented 8 years ago

Hi Thank you for the useful plugin!

In close method of the anonymous PageOutput class, close method of the argument output is not called. https://github.com/sonots/embulk-filter-column/blob/master/src/main/java/org/embulk/filter/ColumnFilterPlugin.java#L329 Therefore close method of the following output plugin is not called.

You may need to call finish method of the argument output in finish method of the anonymous PageOutput class.

Thanks

sonots commented 8 years ago

It seemed this is a bug of embulk itself https://github.com/embulk/embulk/pull/394

hito4t commented 8 years ago

Thank you!