search

embulk / embulk-input-jdbc

MySQL, PostgreSQL, Redshift and generic JDBC input plugins for Embulk
Other
102 stars 74 forks source link

Use the MySQL/PostgreSQL JDBC driver found in the class loader in the highest priority #233

Closed dmikurube closed 2 years ago

dmikurube commented 2 years ago

The JDBC plugins will be available as Maven-based plugins. To make it realized, their pom.xml should include MySQL/PostgreSQL JDBC drivers so that Embulk's PluginClassLoader can find the JDBC drivers from pom.xml. Then, they are loaded straightforward from the class loader.

But currently, their driver finding mechanism does not prioritize classes found straightforward from the class loader.

This pull request changes the priority, including some refactoring with exception/log message changes.

vietnguyen-td commented 2 years ago

fyi, i just realized the current CI is failed but it is return success check

dmikurube commented 2 years ago

You mean some failures in checkstyle? If so, yeah, I also noticed, but they're configured non-critical. We may want to address them later...

dmikurube commented 2 years ago

Thanks!