search

embulk / embulk-output-elasticsearch

Apache License 2.0
32 stars 26 forks source link

Show warning logs instead of throwing ConfigException for AWS ES #49

Closed sakama closed 5 years ago

sakama commented 6 years ago

Fix for #24

We're now throwing ConfigException when Es host URI ends with es.amazonaws.com.

AWS Elasticsearch Service supported AWS VPC at Oct 2017 and user is able to access to Es without any Authentication. Amazon Elasticsearch Service now supports VPC | AWS News Blog

I changed implementation to show warn logs instead of throwing ConfigException. And confirmed this change works fine at EC2 instance located at VPC network/subnet.

muga commented 6 years ago

@sakama thank you for fixing. I'm OK to change it with warning message only. And what do you think that it could output more details like "AWS Elasticsearch Service supported AWS VPC at Oct 2017 and user is able to access to Es without any Authentication." that you described above? And if you get a chance, please update README as well.

sakama commented 6 years ago

@muga Thanks for your review. I updated README and add link from log.

What do you think about?

sakama commented 5 years ago

Let me merge this PR. Please let me know if you have any concerns.