Test with GitHub Actions for embulk output DB2, MySQL, PostgreSQL, Redshift

embulk / embulk-output-jdbc

MySQL, PostgreSQL, Redshift and generic JDBC output plugins for Embulk

Other

88 stars 86 forks source link

Test with GitHub Actions for embulk output DB2, MySQL, PostgreSQL, Redshift #279

Closed vietnguyen-td closed 4 years ago

vietnguyen-td commented 4 years ago

Enable GitHub action for db2, PostgreSQL,MySQL, Redshift
And change the way to verify the test result in DB2 & Mysql by opening connection & resultset (In my opinion, execute clpplus or mysql command to export to file is not easy for maintenance ( need some setup to able to run the test ) and need the volume binding config when setup with docker github (config temp folder to write temp file)

dmikurube commented 4 years ago

@hito4t Can you have a look at this?

It does not include automated testing with SQLServer and Oracle. He has been trying SQLServer in #280, but not complete yet. We gave up with Oracle even in embulk-input-jdbc.

We made further updates #272, #273, #274, #275, and #276 based on this testing PR even while SQLServer and Oracle are not included. But, I believed it should be fine as they were not tested even on Travis-CI. Can we hear your thoughts?

I think we'll start our own review process, and merging from next Monday (Aug 24), even before you start leaving your comments. (When you have comments, we'll address that before merging.)

hito4t commented 4 years ago

@dmikurube @vietnguyen-td

I like the idea not to use clpplus and mysql commands. I thought to do that in embulk-input-jdbc at first, but I didn't have time to try that, then. Good job.

I agree with you. Using JDBC instead of clpplus and mysql commands is a good idea, because the commands are sensitive to the environment.

hito4t commented 4 years ago

We made further updates #272, #273, #274, #275, and #276 based on this testing PR even while SQLServer and Oracle are not included. But, I believed it should be fine as they were not tested even on Travis-CI. Can we hear your thoughts?

It is not easy to build CI environment for some DBMSs. I think it is enough to test manually for them before release.

dmikurube commented 4 years ago

Thanks! Let me merge this. We'll have another review for other PRs.