embulk / embulk-output-jdbc

MySQL, PostgreSQL, Redshift and generic JDBC output plugins for Embulk
Other
88 stars 87 forks source link

Catch up with Embulk v0.10 API/SPI in embulk-output-jdbc:0.10.0 #292

Closed dmikurube closed 3 years ago

dmikurube commented 3 years ago

The next version will be a big change again, then bumping up to v0.10.0, not v0.9.1.

v0.10.0 plans to :

For the Embulk v0.10 API/SPI catchup, please see https://dev.embulk.org/topics/get-ready-for-v0.11-and-v1.0.html and https://github.com/embulk/embulk-input-jdbc/pull/207, too.

dmikurube commented 3 years ago

@hito4t Thanks for your comment! Good catch. We needed an equivalent to : https://github.com/google/guava/blob/v18.0/guava/src/com/google/common/math/DoubleMath.java#L157

Addressed in 36c8950418dfbfdf4f4e634ae5b97e89b744547c. Could you have another look?

dmikurube commented 3 years ago

Thanks!