search

embulk / embulk-output-jdbc

MySQL, PostgreSQL, Redshift and generic JDBC output plugins for Embulk
Other
88 stars 86 forks source link

Fix a compile error in embulk-output-sqlserver #296

Closed dmikurube closed 3 years ago

dmikurube commented 3 years ago

I found that embulk-output-sqlserver was failing to compile when I tried to release 0.10.0. We were not able to detect it beforehand as it was not tested in GitHub Actions.

This PR fixes the compile error, and adds "build-only" check in GitHub Actions for the time being.

Testing embulk-output-sqlserver on GitHub Actions would be addressed in #280 later...

dmikurube commented 3 years ago

Thanks!

@hito4t We're going to merge this as it's a simple fix, and to release embulk-output-jdbc/mysql/postgresql/redshift/sqlserver v0.10.0 soon. Please let us know if you see any concerns.

dmikurube commented 3 years ago

Released v0.10.0 by:


./gradlew embulk-output-jdbc:publishMavenPublicationToMavenCentralRepository embulk-output-jdbc:gemPush embulk-output-mysql:publishMavenPublicationToMavenCentralRepository embulk-output-mysql:gemPush embulk-output-postgresql:publishMavenPublicationToMavenCentralRepository embulk-output-postgresql:gemPush embulk-output-redshift:publishMavenPublicationToMavenCentralRepository embulk-output-redshift:gemPush embulk-output-sqlserver:publishMavenPublicationToMavenCentralRepository embulk-output-sqlserver:gemPush```
dmikurube commented 3 years ago