Check with GitHub Actions v3

embulk / embulk-output-jdbc

MySQL, PostgreSQL, Redshift and generic JDBC output plugins for Embulk

Other

88 stars 86 forks source link

Check with GitHub Actions v3 #314

Closed hiroyuki-sato closed 1 year ago

hiroyuki-sato commented 1 year ago

Use actions/checkout@v3, actions/setup-java@v3 and actions/upload-artifact@v3
Use temurin JDK (It's the same JDK as the Embulk repository.)
Run on push and pull_request (from a forked repository only)
Add gradle cache.
Add fail-fast strategy.

@dmikurube Could you take a look when you get a chance? Especially, gradle and strategy part.

dmikurube commented 1 year ago

Let's rename build.yml to check.yml, and change name: Build and test to name: Check, to follow other repos consistently. Others look good.

hiroyuki-sato commented 1 year ago

Thank you for your review.

Renamed build.yml to check.yml
change name: Build and test to name: Check.
Force pushed

diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
index be1ad5e..c67fd2d 100644
--- a/.github/workflows/check.yml
+++ b/.github/workflows/check.yml
@@ -1,4 +1,4 @@
-name: Build and test
+name: Check
 on: push
 jobs:
   mysql:

hiroyuki-sato commented 1 year ago

Thanks!