Added max_s3_upload_threads_per_task option to Redshift

embulk / embulk-output-jdbc

MySQL, PostgreSQL, Redshift and generic JDBC output plugins for Embulk

Other

88 stars 86 forks source link

Closed t3t5u closed 6 months ago

t3t5u commented 7 months ago

The changes are essentially the same as in this PR. I've fixed the points commented on in the above review.

t3t5u commented 7 months ago

@dmikurube @hiroyuki-sato Please review. 🙇‍♂️

t3t5u commented 7 months ago

@hiroyuki-sato

I tought This PR was proposed for replace #311. Correct?

That is correct. This PR is a reworked replacement for #311.

otherwise, Let's keep current behavior.

Thank you for the advice. I think the default behavior doesn't need to be changed at this time.

hiroyuki-sato commented 7 months ago

@t3t5u Thanks! LGTM👍

dmikurube commented 6 months ago

Thanks for your contribution. Merging this for v0.10.5...