embyt / enocean-mqtt

Receives messages from an enOcean serial interface (USB) and provides selected messages to an MQTT broker.
GNU General Public License v3.0
42 stars 21 forks source link

Multi-level grouping & handling of packet.learn #35

Closed mak-gitdev closed 2 years ago

mak-gitdev commented 2 years ago
romor commented 2 years ago

Thanks a lot for this useful contribution!

I have only a minor formal comment. According my understanding variable names with an underscore prefix are considered unused or private. This does not really fit to _id? Maybe id_ or cur_id would be better?

Btw, did you try to run pylint on the code? I guess it should warn on this.

Do you want to fix this or shall I just merge the pull request as it is?

mak-gitdev commented 2 years ago

Hello @romor

I just made a new commit to take into account your comments. I will run pylint on the code from now. Thanks !