search

emcho / trickle-ice

Trickle ICE: Incremental Provisioning of Candidates for the Interactive Connectivity Establishment (ICE) Protocol
3 stars 4 forks source link

Feedback from Rajmohan Banavi on mmusic #7

Closed emcho closed 9 years ago

emcho commented 9 years ago 
"Sec 4 Determining Support for Trickle ICE" - "According to [RFC5245] every time an agent supporting trickle ICE generates an offer or an answer,". 

Need to be reworded as RFC 5245 has no idea of trickle

"According to [RFC5245] every time an agent supporting an extension generates an offer or answer, it must include an identification token in the ice-options attribute. Accordingly, an agent supporting trickle ICE must include the "trickle" token in the ice-options attribute."

Trivial typo in sec 1 Introduction.  "gathering, candidates" --->  "gathering candidates".

Trivial type. Sec 9.3 - "Announcing End of Candidates". Duplication of sentence

During implementation, one of the issues that surfaced was regarding the check list timer. RFC 5245 Sec 5.8 "Scheduling Checks" mentions that if there is no such pair, "Terminate the timer for that check list". This is obviously not going to work with trickled ice candidates as the candidate pairs list will keep filling up incrementally. So for trickled ice, the conditions for stopping of the check list timer must be changed. Probably the checklist timer must not be stopped until the checklist moves to completed or Failed state.
stpeter commented 9 years ago

On the first point (determining support for Trickle ICE), see https://github.com/emcho/trickle-ice/issues/8

stpeter commented 9 years ago

On the last point (scheduling checks), see https://github.com/emcho/trickle-ice/issues/9

stpeter commented 9 years ago

Closing this issue because I opened more focused issues for the main points.