Clean up - Githubissues

emcniece / DockerYourXyzzy

Dockerized Cards Against Humanity clone - https://github.com/ajanata/PretendYoureXyzzy

71 stars 38 forks source link

Clean up #17

Closed Cyb3r-Jak3 closed 3 years ago

Cyb3r-Jak3 commented 3 years ago

Adds a test workflow for branches other than master
Makes it so the entrypoint.sh script is used
Removed no longer needed work around

emcniece commented 3 years ago

🔥 Thanks for the PR! Got a few questions.

Cyb3r-Jak3 commented 3 years ago

The latest changes allow for runtime overrides but remove build time overrides. Adds more to the entrypoint and allows for custom CMD overrides. Also decreases the image size but about 10MB and reduces the number of steps.

Next, I would like to work on making so the container is customizable via environment variables.

emcniece commented 3 years ago

I'll patch the failing check in a second. Thank you again for all of the contributions!