search

emcstack / bonding

Role to configure bonding interfaces
GNU Lesser General Public License v3.0
1 stars 2 forks source link

How do you enable the changes after role has been applied? #5

Open kostyrev opened 8 years ago

kostyrev commented 8 years ago

Obviously, one needs to restart network to activate the changes introduced by with role. How do you do it? Do you have a separate role or something? The kinda obvious flow would be to notify network service

UPD. Yes, I've have read your warning about WIP I'm just curious how you do this stuff at the moment.

JohnPreston commented 8 years ago

As said, I just started to make those small roles and still trying to figure out the right way to do things. The change of settings after creation of the configuration files is something that of course will need to be done by the administrator, but at the moment * and because I have seen it very often * it doesn't do it because this should be in a different step. Here we are simply creating configuration files, which allow to make sure everything seems ok before you apply those. However bonding is different from all the other kind of interface I am working with generally, which are VLANs and bridges, which for those you could do changes on the fly without network restart.

It generates configuration files for the moment, my objective is to do it right and let a bit of room for admins to check on the configuration files (ie: catch doublons if the source configuration is not correct).

kostyrev commented 8 years ago

just use

--check

to

make sure everything seems ok before you apply those

no?

kostyrev commented 8 years ago

if you've got 10 roles that have handler that notifies network service to restart, it would be called just once.

Do not thank me truly yours, capt. Obvious

JohnPreston commented 8 years ago

AFAIK --check will only make sure the play will run properly, not that the values are correct. Let's imagine that for some reason, while you are watching your play going on you realize the IPs are wrong and you had the brilliant idea to mess with the interface you use to get to the machines (that happens very often ..) and the network restarts with the wrong settings. Then you have to get each machine already configured (if you did not -f 1M) and you have to get to each of those manually to fix it via ILO or iDRAC.

kostyrev commented 8 years ago

yes, of course! I meant use

--check --diff

obviously.

to

make sure everything seems ok before you apply those

JohnPreston commented 8 years ago

I will go for a middle-ground solution on this one. Keep tuned