emehrkay / Pypher

Python Cypher Querybuilder
MIT License
170 stars 29 forks source link

__.List() Question #10

Closed g3rd closed 6 years ago

g3rd commented 6 years ago

Why does the List join with a ' ' and not a ', '?

See: https://github.com/emehrkay/Pypher/blob/master/pypher/builder.py#L670

When I do:

...
p.Return.apoc_text_join(__.List(__.u.__first_name__, __.u.__last_name__), "' '"))
...

I'm getting:

RETURN apoc.text.join([u.`first_name` u.`last_name`), " ")
emehrkay commented 6 years ago

I think you’re right. It should join on a comma. Would you mind fixing it (and the tests) and I’ll pull it in a little bit later?

emehrkay commented 6 years ago

This should be fixed in 0.9.2

g3rd commented 6 years ago

You beat me to it!