emekalites / react-native-alarm-notification

schedule alarm and local notification in react-native
https://www.npmjs.com/package/react-native-alarm-notification
MIT License
223 stars 94 forks source link

[BUG] Package wouldn't let app compile in Gradle 7x #181

Open Amitb01FUB opened 1 year ago

Amitb01FUB commented 1 year ago

Found a fix for that particular problem, as said by @wcosmas in #175 maven was remove in Gradle 7. This whole repo won't compile in Gradle 7, to fix that, you need to make some changes to the buid.gradle file inside the module folder (node_modules\react-native-alarm-notification\android\build.gradle)

line 23: apply plugin: 'maven-publish'

line 43: apply plugin: 'maven-publish'

line 112 replace the whole task block:

task androidJavadoc(type: Javadoc) {
        project.configurations.getByName("implementation").setCanBeResolved(true)
        source = android.sourceSets.main.java.srcDirs
        classpath += files(android.bootClasspath)
        classpath += files(project.getConfigurations().getByName('implementation').asList())
        include '**/*.java'
    }

line 145 comment/remove the whole task block:

// task installArchives(type: Upload) {
//     configuration = configurations.archives
//     repositories.mavenDeployer {
//         // Deploy to react-native-event-bridge/maven, ready to publish to npm
//         repository url: "file://${projectDir}/../android/maven"
//         configureReactNativePom pom
//     }
// }

(honestly anything past line 108 is probably not needed for this to run but I didn't check)

after that the app will build with Gradle >=7

Originally posted by @Amitb01FUB in https://github.com/emekalites/react-native-alarm-notification/issues/175#issuecomment-1243046400

eggn commented 1 year ago

Same here.

build.gradle ... dependencies { classpath("com.android.tools.build:gradle:7.2.1") classpath("com.facebook.react:react-native-gradle-plugin") classpath("de.undercouch:gradle-download-task:5.0.1") }

gradle-wrapper.properties

distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists

"react": "18.1.0", "react-native": "0.70.0",

jorgerojas26 commented 1 year ago

This solved my problem. Thank you.