emencia / diskette

💾 Export and import Django application data and medias
https://diskette.readthedocs.io/
MIT License
1 stars 0 forks source link

Empty dump management #8

Closed sveetch closed 8 months ago

sveetch commented 8 months ago

Is your feature request related to a problem? Please describe.

Currently, when a dump does not have any data, the dump is still created but empty. Then diskette_load try to load it like the other, it won't fail but output a warning about empty data and that it is possible corrupted or invalid.

Describe the solution you'd like

The empty dump itself is harmless since it does not fail and is around 6byte size. However it can be troublesome to users to see warning when loading dumps with empty data.

sveetch commented 8 months ago

LoaddataSerializerAbstract.call can know the size of dump but it may not be the better place, Loader.deploy_datas would have been better for filtering.

For how to know if a dump is empty:

sveetch commented 8 months ago

Done in v0.3.5-pre.2 except it does not "let if flow to the django call command", so if file does not exists, this will fail with an exception.