search

emencia / emencia-django-newsletter

An app for sending newsletter by email to a contact list.
189 stars 72 forks source link

Hardcoded French? #20

Closed girzel closed 13 years ago

girzel commented 13 years ago

The two templates:

newsletter_link_site.html newsletter_link_unsubscribe.html

Seem to contain hardcoded (no i18n translation) French strings for viewing the newsletter onsite or unsubscribing. Surely this isn't the way it's meant to be? Am I supposed to override these templates with my own, or wouldn't it make sense to use translated strings here...

Fantomas42 commented 13 years ago

Hi taojian,

thank you for your report, effectively, these strings are hardcoded in French...

At first, I thought I have made a mistake, but I remembered that these templates are included without language information, because they are used without the request, directly when the email's content is generated, so translations are not possible.

Perhaps my conclusions are wrong, so I need to retest the behavior of these templates, with the trans tag.

For you, the quickest solution is to override these templates, in your language, because I have not the time this week to make the necessary debugging.

Have a nice day.

Fantomas42 commented 13 years ago

Hi taojian,

the problem is now fixed in Fantomas42/emencia-django-newsletter@2f45ad7f410e0f4a06a377092c899942cabf081c

The activate function in the send_newsletter command do the job.

Regards.