search

emencia / emencia-django-newsletter

An app for sending newsletter by email to a contact list.
189 stars 72 forks source link

Newsletter status is updated to sent although not all contacts received it. #5

Closed chliviu closed 14 years ago

chliviu commented 14 years ago

If my mailing list consists on 2000 contacts, the SMTP server emails per hour set to 100, it will only generate 100 emails and send them, and change the newsletters status to sent. The next time the cron is ran, it doesnt create the newsletter for the other contacts because the status is sent.

My fix (line numbers may be different) in mailer.py: <-- removed -->

Fantomas42 commented 14 years ago

Ok I will check this, and try to reproduce the bug.

Fantomas42 commented 14 years ago

I have wrote a test to reproduce the bug, and effectively I've made a mistake. But it seem your fix can't work properly because, get_expedition_list is still filtered to exclude already sent message, so the value is not valid

Thank for the report, the bug is fixed !