search

emencia / emencia-django-newsletter

An app for sending newsletter by email to a contact list.
189 stars 72 forks source link

SMTPServer.credits() negative value returned bug #52

Closed danielsokolowski closed 12 years ago

danielsokolowski commented 12 years ago

Hi Fache ,

During development I run into assertion error where credits value returned was a negative; this commit fixes this situation from happening.

Hope you will consider pulling this, Thanks

Daniel

danielsokolowski commented 12 years ago

Please cherry pick only the https://github.com/danols/emencia-django-newsletter/commit/eec011d1556f18042563577c2f5c3cf0710c7817 I have not yet modified the '999 sqlite3 variable' tweak.

Fantomas42 commented 12 years ago

I prefer keep a negative value, in the SMTPServer instance, and treat this case directly in the Mailer.

An information is an information :)

danielsokolowski commented 12 years ago

It actually crashed the execution, it wasn't informational only --- is that what you prefer it still happen ?