search

emencia / emencia-django-newsletter

An app for sending newsletter by email to a contact list.
189 stars 72 forks source link

Suscribe to a mailing list #7

Closed lucalenardi closed 14 years ago

lucalenardi commented 14 years ago

Another feature request, I suppose.

I'm looking for a simple form to let users subscribe to a mailing list within a public site. It could be something similar to how the view_mailinglist_unsubscribe view works, but with the ability to create a new contact before adding it to the selected mailing list.

Do you believe that such a feature could be useful?

Thanks.

Fantomas42 commented 14 years ago

Yes this feature could be usefull, and she's planned for the weeks to come. I remind that I have started to look in, but a problem appears and I don't remember which.

lucalenardi commented 14 years ago

I've added a "very basic" support for this feature in my fork. Please, take a look at it so we can start discussing how to go further. Thanks.

lucalenardi commented 14 years ago

For example: it could be useful to have a flag on the MailingList model to decide whether a user can subscribe by herself or not. Something like "opened/closed to public subscription".

Fantomas42 commented 14 years ago

I've take a look, and it's a good job ! I will merge your modifications in my branch.

But I will add a feature, instead of choosing the mailing list you want to subscribe in the form, it can be usefull to have a kind of "templatetags" or views for allowing susbscriptions directly to a mailing list.

I will try to do that tomorrow.

Fantomas42 commented 14 years ago

Ok I've merged your modifications and adding support for independant mailing lists. Now we can register to a single mailing list.

But the idea to use a open/close boolean on the mailing list is not ready. And I think I need to rewrite some code in the views and forms for the email check.

Fantomas42 commented 14 years ago

Rewriting views, but not using boolean for open/close mailing list, the cases for using this feature are really rare. http://github.com/Fantomas42/emencia-django-newsletter/commit/49954fb6d8525461bb53f683e86edb8c083c0d02