emer / axon

Axon is a spiking, biologically-based neural model driven by predictive error-driven learning, for systems-level models of the brain
BSD 3-Clause "New" or "Revised" License
20 stars 7 forks source link

Have BOA test assert on key statistics #207

Closed garymm closed 1 year ago

garymm commented 1 year ago

This will make it easier to check if things are working without looking at the GUI.

Move the old race-detector test to a separate file so we can run it only when race detector is enabled. The new test is too slow with the race detector enabled, and the old test is worthless with it disabled.

And some minor clean-up in boa example:

etuleu commented 1 year ago

Looks like the tests got stuck downloading some packages. I re-ran them and hopefully will work this time.

etuleu commented 1 year ago

Looks like the tests got stuck downloading some packages. I re-ran them and hopefully will work this time.

No actually the tests are timing out. Maybe try extending the timeout? Not sure if we want to run these in CI since they are a bit long.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 14.94% and project coverage change: -3.13 :warning:

Comparison is base (7e9561c) 40.34% compared to head (673fb36) 37.21%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #207 +/- ## ========================================== - Coverage 40.34% 37.21% -3.13% ========================================== Files 53 54 +1 Lines 10222 11030 +808 ========================================== - Hits 4124 4105 -19 - Misses 5865 6689 +824 - Partials 233 236 +3 ``` | [Impacted Files](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | Coverage Δ | | |---|---|---| | [axon/deep\_layers.go](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9kZWVwX2xheWVycy5nbw==) | `13.97% <0.00%> (-6.25%)` | :arrow_down: | | [axon/deep\_net.go](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9kZWVwX25ldC5nbw==) | `0.00% <0.00%> (ø)` | | | [axon/deep\_prjns.go](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9kZWVwX3Byam5zLmdv) | `0.00% <0.00%> (ø)` | | | [axon/layer\_compute.go](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sYXllcl9jb21wdXRlLmdv) | `42.57% <0.00%> (-0.96%)` | :arrow_down: | | [axon/layertypes.go](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sYXllcnR5cGVzLmdv) | `41.66% <ø> (ø)` | | | [axon/layertypes\_string.go](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sYXllcnR5cGVzX3N0cmluZy5nbw==) | `16.66% <ø> (ø)` | | | [axon/networkbase.go](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9uZXR3b3JrYmFzZS5nbw==) | `50.52% <0.00%> (-0.08%)` | :arrow_down: | | [axon/neuron.go](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9uZXVyb24uZ28=) | `81.25% <ø> (ø)` | | | [axon/pcore\_net.go](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9wY29yZV9uZXQuZ28=) | `0.00% <0.00%> (ø)` | | | [axon/prjntypes.go](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9wcmpudHlwZXMuZ28=) | `0.00% <ø> (ø)` | | | ... and [25 more](https://app.codecov.io/gh/emer/axon/pull/207?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

garymm commented 1 year ago

I split the test into race and non-race. Overall CI is a bit slower now but it checks BOA is working at a basic level so I think it's worth it. We can adjust if it's problematic.