Sender-based synapses

[rcoreilly]

switching back to sender-based.

[codecov-commenter]

Codecov Report

Patch coverage: 55.06% and project coverage change: -0.26 :warning:

Comparison is base (339bb20) 37.16% compared to head (9738ffc) 36.90%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #219 +/- ## ========================================== - Coverage 37.16% 36.90% -0.26% ========================================== Files 54 54 Lines 11175 11147 -28 ========================================== - Hits 4153 4114 -39 - Misses 6784 6792 +8 - Partials 238 241 +3 ``` | [Impacted Files](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | Coverage Δ | | |---|---|---| | [axon/gpu.go](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9ncHUuZ28=) | `3.33% <0.00%> (+0.03%)` | :arrow_up: | | [axon/layerparams.go](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sYXllcnBhcmFtcy5nbw==) | `36.42% <0.00%> (ø)` | | | [axon/logging.go](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sb2dnaW5nLmdv) | `0.00% <0.00%> (ø)` | | | [axon/synapse.go](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9zeW5hcHNlLmdv) | `52.63% <ø> (ø)` | | | [examples/bench/bench.go](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-ZXhhbXBsZXMvYmVuY2gvYmVuY2guZ28=) | `0.00% <0.00%> (ø)` | | | [examples/bench\_lvis/bench\_lvis.go](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-ZXhhbXBsZXMvYmVuY2hfbHZpcy9iZW5jaF9sdmlzLmdv) | `0.00% <0.00%> (ø)` | | | [axon/prjn\_compute.go](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9wcmpuX2NvbXB1dGUuZ28=) | `54.77% <50.00%> (-5.13%)` | :arrow_down: | | [axon/threads.go](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi90aHJlYWRzLmdv) | `54.76% <53.22%> (-6.11%)` | :arrow_down: | | [axon/layer\_compute.go](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sYXllcl9jb21wdXRlLmdv) | `43.10% <66.66%> (+0.03%)` | :arrow_up: | | [axon/prjn.go](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9wcmpuLmdv) | `61.14% <77.77%> (ø)` | | | ... and [7 more](https://app.codecov.io/gh/emer/axon/pull/219?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[rcoreilly]

The last sender-based version was: https://github.com/emer/axon/commit/b60251691a43d632e7e157e62b1085744fabe08c released as version 1.7.1 on Jan 25, 2023.

[siboehm]

Oh shit shouldn't have approved bc you had automerger on. Could you respond to the comments regardless? I can make a PR to fix the issues if you like.

[rcoreilly]

There is a lot of discussion on performance issues related to this on slack thread -- I'll tag you on that so you can catch up on that.