Closed rcoreilly closed 1 year ago
given that Simon & Gary didn't review the original GPU stuff, they can probably skip over this too. Sorry for the jumbo PR -- trying to get LVis working and need to check out something on the cluster, so this is it...
also need to figure out how to get codecov to ignore generated files.
Codecov Report
Patch coverage:
31.53
% and project coverage change:-0.50
:warning:Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #245 +/- ## ========================================== - Coverage 32.73% 32.24% -0.50% ========================================== Files 76 77 +1 Lines 13977 14205 +228 ========================================== + Hits 4575 4580 +5 - Misses 9138 9335 +197 - Partials 264 290 +26 ``` | [Impacted Files](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | Coverage Δ | | |---|---|---| | [axon/layer.go](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sYXllci5nbw==) | `33.16% <0.00%> (-0.28%)` | :arrow_down: | | [axon/layer\_compute.go](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sYXllcl9jb21wdXRlLmdv) | `46.71% <0.00%> (-0.16%)` | :arrow_down: | | [axon/layerparams.go](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sYXllcnBhcmFtcy5nbw==) | `37.83% <0.00%> (-0.08%)` | :arrow_down: | | [axon/looper.go](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sb29wZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [examples/pcore/pcore.go](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-ZXhhbXBsZXMvcGNvcmUvcGNvcmUuZ28=) | `0.00% <0.00%> (ø)` | | | [axon/gpu.go](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9ncHUuZ28=) | `3.79% <3.17%> (+0.99%)` | :arrow_up: | | [axon/pvlv\_layers.go](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9wdmx2X2xheWVycy5nbw==) | `5.57% <18.60%> (-1.32%)` | :arrow_down: | | [axon/networkbase.go](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9uZXR3b3JrYmFzZS5nbw==) | `47.37% <35.18%> (-0.95%)` | :arrow_down: | | [examples/boa/boa.go](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-ZXhhbXBsZXMvYm9hL2JvYS5nbw==) | `81.50% <57.69%> (-3.24%)` | :arrow_down: | | [axon/network.go](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9uZXR3b3JrLmdv) | `43.64% <60.00%> (+0.67%)` | :arrow_up: | | ... and [6 more](https://app.codecov.io/gh/emer/axon/pull/245?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.