emer / axon

Axon is a spiking, biologically-based neural model driven by predictive error-driven learning, for systems-level models of the brain
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

key fix for inhibition -- pre-divide by nneurons for both GPU and CPU… #247

Closed rcoreilly closed 1 year ago

rcoreilly commented 1 year ago

… -- more accurate for both -- and thorough tests, plus tolerances per test and shared test funcs

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 1.23% and project coverage change: -1.62 :warning:

Comparison is base (dcb0eb5) 32.24% compared to head (aedde0e) 30.62%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #247 +/- ## ========================================== - Coverage 32.24% 30.62% -1.62% ========================================== Files 77 79 +2 Lines 14205 15158 +953 ========================================== + Hits 4580 4642 +62 - Misses 9335 10257 +922 + Partials 290 259 -31 ``` | [Impacted Files](https://app.codecov.io/gh/emer/axon/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | Coverage Δ | | |---|---|---| | [axon/context.go](https://app.codecov.io/gh/emer/axon/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9jb250ZXh0Lmdv) | `27.16% <ø> (ø)` | | | [axon/gpu.go](https://app.codecov.io/gh/emer/axon/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9ncHUuZ28=) | `3.16% <0.00%> (-0.64%)` | :arrow_down: | | [axon/networkbase.go](https://app.codecov.io/gh/emer/axon/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9uZXR3b3JrYmFzZS5nbw==) | `48.39% <0.00%> (+1.01%)` | :arrow_up: | | [chans/gabab.go](https://app.codecov.io/gh/emer/axon/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-Y2hhbnMvZ2FiYWIuZ28=) | `0.00% <0.00%> (ø)` | | | [examples/bench\_lvis/bench\_lvis.go](https://app.codecov.io/gh/emer/axon/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-ZXhhbXBsZXMvYmVuY2hfbHZpcy9iZW5jaF9sdmlzLmdv) | `0.00% <0.00%> (ø)` | | | [examples/boa/boa.go](https://app.codecov.io/gh/emer/axon/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-ZXhhbXBsZXMvYm9hL2JvYS5nbw==) | `84.87% <0.00%> (+3.36%)` | :arrow_up: | | [examples/neuron/neuron.go](https://app.codecov.io/gh/emer/axon/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-ZXhhbXBsZXMvbmV1cm9uL25ldXJvbi5nbw==) | `0.00% <0.00%> (ø)` | | | [examples/ra25/ra25.go](https://app.codecov.io/gh/emer/axon/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-ZXhhbXBsZXMvcmEyNS9yYTI1Lmdv) | `0.00% <0.00%> (ø)` | | | [axon/layer\_compute.go](https://app.codecov.io/gh/emer/axon/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sYXllcl9jb21wdXRlLmdv) | `46.80% <60.00%> (+0.09%)` | :arrow_up: | | [axon/synapse.go](https://app.codecov.io/gh/emer/axon/pull/247?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9zeW5hcHNlLmdv) | `63.26% <60.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/emer/axon/pull/247/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.