emer / axon

Axon is a spiking, biologically-based neural model driven by predictive error-driven learning, for systems-level models of the brain
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

BOA: rm Approach.LastUS #256

Closed garymm closed 1 year ago

garymm commented 1 year ago

it is always equal to US when it is checked

also minor simplificaiton of if / else in Approach.Action

Change-Id: I0a5bf75ad3a0c0f734ecb45ce2c7b44cacd61ba8

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.78 :warning:

Comparison is base (dcb0eb5) 32.24% compared to head (0b4296f) 30.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #256 +/- ## ========================================== - Coverage 32.24% 30.46% -1.78% ========================================== Files 77 79 +2 Lines 14205 15153 +948 ========================================== + Hits 4580 4617 +37 - Misses 9335 10270 +935 + Partials 290 266 -24 ``` | [Impacted Files](https://app.codecov.io/gh/emer/axon/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | Coverage Δ | | |---|---|---| | [examples/boa/approach\_env.go](https://app.codecov.io/gh/emer/axon/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-ZXhhbXBsZXMvYm9hL2FwcHJvYWNoX2Vudi5nbw==) | `89.22% <100.00%> (+11.68%)` | :arrow_up: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/emer/axon/pull/256/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.