emer / axon

Axon is a spiking, biologically-based neural model driven by predictive error-driven learning, for systems-level models of the brain
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

BOA: rm Approach.LastUS #257

Closed garymm closed 1 year ago

garymm commented 1 year ago

it is always equal to US when it is checked

also minor simplificaiton of if / else in Approach.Action

Change-Id: I0a5bf75ad3a0c0f734ecb45ce2c7b44cacd61ba8

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.16 :warning:

Comparison is base (31cc3f3) 30.62% compared to head (a0ef91f) 30.46%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #257 +/- ## ========================================== - Coverage 30.62% 30.46% -0.16% ========================================== Files 79 79 Lines 15157 15153 -4 ========================================== - Hits 4642 4617 -25 - Misses 10256 10270 +14 - Partials 259 266 +7 ``` | [Impacted Files](https://app.codecov.io/gh/emer/axon/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | Coverage Δ | | |---|---|---| | [examples/boa/approach\_env.go](https://app.codecov.io/gh/emer/axon/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-ZXhhbXBsZXMvYm9hL2FwcHJvYWNoX2Vudi5nbw==) | `89.22% <100.00%> (-1.88%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/emer/axon/pull/257/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

garymm commented 1 year ago

Hmm this might not be right. Investigating.