codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 30.90% and project coverage change: -0.39 :warning:
Comparison is base (
9538994) 30.62% compared to head (db32d25) 30.23%.:exclamation: Current head db32d25 differs from pull request most recent head 2e11763. Consider uploading reports for the commit 2e11763 to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #266 +/- ## ========================================== - Coverage 30.62% 30.23% -0.39% ========================================== Files 79 79 Lines 15152 15186 +34 ========================================== - Hits 4640 4592 -48 - Misses 10255 10332 +77 - Partials 257 262 +5 ``` | [Impacted Files](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | Coverage Δ | | |---|---|---| | [axon/context.go](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9jb250ZXh0Lmdv) | `27.21% <ø> (+0.05%)` | :arrow_up: | | [axon/deep\_net.go](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9kZWVwX25ldC5nbw==) | `0.00% <0.00%> (ø)` | | | [axon/globals.go](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9nbG9iYWxzLmdv) | `0.00% <ø> (ø)` | | | [axon/globalvars\_string.go](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9nbG9iYWx2YXJzX3N0cmluZy5nbw==) | `0.00% <ø> (ø)` | | | [axon/gpu.go](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9ncHUuZ28=) | `3.17% <0.00%> (+<0.01%)` | :arrow_up: | | [axon/helpers.go](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9oZWxwZXJzLmdv) | `0.00% <0.00%> (ø)` | | | [axon/layerbase.go](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sYXllcmJhc2UuZ28=) | `45.45% <0.00%> (-0.08%)` | :arrow_down: | | [axon/looper.go](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9sb29wZXIuZ28=) | `0.00% <0.00%> (ø)` | | | [axon/networkbase.go](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9uZXR3b3JrYmFzZS5nbw==) | `45.87% <0.00%> (-2.52%)` | :arrow_down: | | [axon/prjnbase.go](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9wcmpuYmFzZS5nbw==) | `50.97% <0.00%> (-0.20%)` | :arrow_down: | | ... and [15 more](https://app.codecov.io/gh/emer/axon/pull/266?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/emer/axon/pull/266/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
main thing is new econfig framework instead of only startup args via ecmd ss.Args.
Saving params as TOML required changing params.Sets to a map instead of a slice -- mostly that is an improvement but does require changing any ParamSet literals to move the name of the Set outside of the { because it is now a map.
Fixes VSPatch learning rule to not multiply by activation of VSPatch -- should be more robust.