emer / axon

Axon is a spiking, biologically-based neural model driven by predictive error-driven learning, for systems-level models of the brain
BSD 3-Clause "New" or "Revised" License
20 stars 7 forks source link

AddHip in hip_net.go for modular hip #272

Closed zycyc closed 1 year ago

zycyc commented 1 year ago

tested and compatible w/ hip.go in #270 @rcoreilly

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.16 :warning:

Comparison is base (a3b284b) 30.26% compared to head (d0b5086) 30.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #272 +/- ## ========================================== - Coverage 30.26% 30.10% -0.16% ========================================== Files 84 85 +1 Lines 15204 15281 +77 ========================================== Hits 4601 4601 - Misses 10343 10420 +77 Partials 260 260 ``` | [Impacted Files](https://app.codecov.io/gh/emer/axon/pull/272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | Coverage Δ | | |---|---|---| | [axon/hip\_net.go](https://app.codecov.io/gh/emer/axon/pull/272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9oaXBfbmV0Lmdv) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rcoreilly commented 1 year ago

with that many args, it probably makes more sense to use a HipConfig struct as the arg to this function. Then you can add descriptions for the meaning of each arg. also rebase or merge to current master.

zycyc commented 1 year ago

should be good for review

rcoreilly commented 1 year ago

also don't forget to update to master (rebase or merge)

zycyc commented 1 year ago

done and rebased.