Closed zycyc closed 1 year ago
Patch coverage has no change and project coverage change: -0.16
:warning:
Comparison is base (
a3b284b
) 30.26% compared to head (d0b5086
) 30.10%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
with that many args, it probably makes more sense to use a HipConfig struct as the arg to this function. Then you can add descriptions for the meaning of each arg. also rebase or merge to current master.
should be good for review
also don't forget to update to master (rebase or merge)
done and rebased.
tested and compatible w/ hip.go in #270 @rcoreilly