search

emer / axon

Axon adds axonal spiking to the Leabra framework for error-driven and associative learning
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

moved ConfigLoopsHip to hip_net.go for modular hip loops #275

Closed zycyc closed 1 year ago

zycyc commented 1 year ago

turned out to work just fine after migration @rcoreilly . rebased and should be ready

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.14 :warning:

Comparison is base (62d0533) 30.10% compared to head (95cbb0d) 29.96%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #275 +/- ## ========================================== - Coverage 30.10% 29.96% -0.14% ========================================== Files 85 85 Lines 15283 15353 +70 ========================================== Hits 4601 4601 - Misses 10422 10492 +70 Partials 260 260 ``` | [Impacted Files](https://app.codecov.io/gh/emer/axon/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | Coverage Δ | | |---|---|---| | [axon/hip\_net.go](https://app.codecov.io/gh/emer/axon/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9oaXBfbmV0Lmdv) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rcoreilly commented 1 year ago

Looks good but probably better in the long run to also use a HipModConfig struct instead of the args -- then if we need to add something in the future it is easier, and the comments provide info to user about the meaning etc.

rcoreilly commented 1 year ago

also needs to be updated with master, and do go configure just to be sure.