Closed zycyc closed 1 year ago
Patch coverage has no change and project coverage change: -0.14
:warning:
Comparison is base (
62d0533
) 30.10% compared to head (95cbb0d
) 29.96%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Looks good but probably better in the long run to also use a HipModConfig struct instead of the args -- then if we need to add something in the future it is easier, and the comments provide info to user about the meaning etc.
also needs to be updated with master, and do go configure just to be sure.
turned out to work just fine after migration @rcoreilly . rebased and should be ready