emer / axon

Axon is a spiking, biologically-based neural model driven by predictive error-driven learning, for systems-level models of the brain
BSD 3-Clause "New" or "Revised" License
19 stars 7 forks source link

prevent drive going negative in PVLVDriveUpdt #277

Closed rcoreilly closed 1 year ago

rcoreilly commented 1 year ago

in eboa it was going negative. basic fix.

rcoreilly commented 1 year ago

well I tried to do two separate PRs but I guess I failed -- can't seem to get the previous one to push as a separate entity. probably I needed to push it before making a new branch off of it?

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01% :warning:

Comparison is base (62d0533) 30.10% compared to head (907c333) 30.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #277 +/- ## ========================================== - Coverage 30.10% 30.09% -0.01% ========================================== Files 85 85 Lines 15283 15286 +3 ========================================== Hits 4601 4601 - Misses 10422 10425 +3 Partials 260 260 ``` | [Files Changed](https://app.codecov.io/gh/emer/axon/pull/277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | Coverage Δ | | |---|---|---| | [axon/context.go](https://app.codecov.io/gh/emer/axon/pull/277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9jb250ZXh0Lmdv) | `27.05% <0.00%> (-0.17%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.