search

emer / axon

Axon is a spiking, biologically-based neural model driven by predictive error-driven learning, for systems-level models of the brain
BSD 3-Clause "New" or "Revised" License
19 stars 7 forks source link

params to rely mostly on MaintInhib instead of SC novelty per #236 #278

Closed rcoreilly closed 1 year ago

rcoreilly commented 1 year ago

… seems to work. also new PTp params are making rewpred work much better -- getting closer to Rew

rcoreilly commented 1 year ago

This is rather annoying: by increasing the dependence on PTMaint -> MaintInhib of ACh, we make the tests much more sensitive -- even between mac (where the test data is generated) vs. CI linux, we get diff results on the Std test, in ACh values. Will just filter those out.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.12% :warning:

Comparison is base (33e70a0) 30.26% compared to head (eb1a397) 30.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #278 +/- ## ========================================== - Coverage 30.26% 30.14% -0.12% ========================================== Files 85 85 Lines 15345 15345 ========================================== - Hits 4644 4626 -18 - Misses 10442 10455 +13 - Partials 259 264 +5 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/emer/axon/pull/278/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.