emer / axon

Axon adds axonal spiking to the Leabra framework for error-driven and associative learning
BSD 3-Clause "New" or "Revised" License
18 stars 8 forks source link

PVLV: fix neg US code #279

Closed garymm closed 1 year ago

garymm commented 1 year ago

Previous code was treating neg US as a drive, but it's not stored with the drives.

Delete PVLVHasNegUS: It was wrong and unused.

Change-Id: Iea0cd44c4cd3dd2b30968632cc8083c407a0ea25

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 60.00% and project coverage change: +0.30% :tada:

Comparison is base (7056120) 29.96% compared to head (bf8bd69) 30.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #279 +/- ## ========================================== + Coverage 29.96% 30.26% +0.30% ========================================== Files 85 85 Lines 15356 15345 -11 ========================================== + Hits 4601 4644 +43 + Misses 10495 10442 -53 + Partials 260 259 -1 ``` | [Files Changed](https://app.codecov.io/gh/emer/axon/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer) | Coverage Δ | | |---|---|---| | [examples/pvlv/effort\_plot.go](https://app.codecov.io/gh/emer/axon/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-ZXhhbXBsZXMvcHZsdi9lZmZvcnRfcGxvdC5nbw==) | `0.00% <0.00%> (ø)` | | | [axon/context.go](https://app.codecov.io/gh/emer/axon/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=emer#diff-YXhvbi9jb250ZXh0Lmdv) | `36.47% <100.00%> (+9.42%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.