Closed etuleu closed 1 year ago
Patch coverage has no change and project coverage change: -0.04%
:warning:
Comparison is base (
80cbe43
) 30.01% compared to head (4dfc1fb
) 29.97%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Logically, there is no connection between positive and negative USs. VsMatrix and OFCus are all organized around positive USs. Therefore, it only makes sense to have full projections from Neg to these layers. Can you give that a try?
Also, don't forget to run boa TestStdCPUnData1 with SaveStandard = true to update test results after updating something like this, to pass the tests.
Made the changes. Take a look again please.
I am not sure about these so please review carefully @rcoreilly