search

emer / etable

Data table structure in Go, now developed at https://github.com/cogentcore/core/tree/main/tensor
BSD 3-Clause "New" or "Revised" License
117 stars 9 forks source link

Plotting: request ability to turn on/off variables as sets #20

Closed rohrlich closed 3 years ago

rohrlich commented 3 years ago

I looked at "Filter" and it wasn't what I expected. What would make my work less tedious is to be able to set the checkboxes for say, "All Dead" or "All CosDiff", etc. This could be done with a string, variable name contains ...

BTW - I'd like to change the description on the Filter button to, "Filter by column name and row value" to be clear that this is for filtering by value and not by column.

Let me know what you think. I can implement if you want and we decide on a button name/interface.

rcoreilly commented 3 years ago

I changed the description to: "Filter rows by values in given column name..." -- the original came from IdxView where the context was clear but that comment on its own was not very clear!

So what you want is, on the plot itself, to toggle checkboxes according to a column name contains expr? That's easy.. I'll add that too -- will just take a sec.

rohrlich commented 3 years ago

Yep, that would be great!

rcoreilly commented 3 years ago

ok give it a try..

rohrlich commented 3 years ago

Functionality is as requested and very useful, thanks! I think a button would be a little less odd and more discoverable. If you stick with checkbox I have some suggestions.

rohrlich commented 3 years ago

Advantage of single checkbox is it is more like toggle but would definitely be better if it stayed open.

rcoreilly commented 3 years ago

Not sure about which checkboxes you're talking about, but the std of having a checkbox at top of list of checkboxes that turns them all on or off is pretty common. I should add a separator between top row and actual column list.

the dialog doesn't stay open because it is a generic CallMethod dialog -- I guess we could add an option for those to remain persistent and have an "Apply" button..

rohrlich commented 3 years ago

Separator is a good idea and simple I assume.

Would be nice if it stayed open but obviously not a high priority.

rcoreilly commented 3 years ago

ps. been using extensively now on new wwi3d sim -- very helpful and seems good enough to me..