search

emer / etable

Data table structure in Go, now developed at https://github.com/cogentcore/core/tree/main/tensor
BSD 3-Clause "New" or "Revised" License
117 stars 9 forks source link

remove dependencies from core packages onto gi #49

Closed garymm closed 1 year ago

garymm commented 1 year ago

Users who don't need graphics shouldn't need to fetch and build gi, which is large and requires Vulkan to be set up to build.

Helpful for https://github.com/Astera-org/obelisk/issues/233

rcoreilly commented 1 year ago

@garymm that won't work as I mentioned in slack -- the gi.FileName is essential for the GUI use of these objects.

I just looked at utils/etcat and it does seem that it includes the gui stuff even for a non-gui build, at least on a mac:

oreilly@mshadow:~/emer/etable/utils/etcat/ > otool -L etcat
etcat:
    /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1858.112.0)
    /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa (compatibility version 1.0.0, current version 23.0.0)
    /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit (compatibility version 1.0.0, current version 275.0.0)
    /System/Library/Frameworks/IOSurface.framework/Versions/A/IOSurface (compatibility version 1.0.0, current version 1.0.0)
    /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore (compatibility version 1.2.0, current version 1.11.0)
    /System/Library/Frameworks/Metal.framework/Versions/A/Metal (compatibility version 1.0.0, current version 261.13.0)
    @rpath/libMoltenVK.dylib (compatibility version 1.0.0, current version 1.0.0)
    /usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1300.23.0)
    /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3)
rcoreilly commented 1 year ago

Assuming we're good to close now..