search

emeraldpay / dshackle

Fault Tolerant Load Balancer for Ethereum and Bitcoin APIs
Apache License 2.0
298 stars 65 forks source link

feat: Dockerfile support #279

Closed barnabasbusa closed 5 months ago

barnabasbusa commented 7 months ago

Closes: #277

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

splix commented 7 months ago

@barnabasbusa let me think about this.

Having a Dockerfile seems to be a very confusing for Java developers, because it's expected to use Jib plugin, which is configured in Gradle. So I'm trying to figure out if it's possible to make a one liner instead of a whole Dockerfile.

Anyway, wanted to ask about your use case for this. Because as I see it, for anyone who changes the code it's a non-issues because he would definitely have a JVM or JDK installed. For others, who don't change the code, there is a CI action that makes a public build after each commit into master branch. Can you tell me more what you're trying reach? Here, or on Discord. Thank you

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6fd701b) 57.98% compared to head (88e20d1) 57.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #279 +/- ## ========================================= Coverage 57.98% 57.98% Complexity 1801 1801 ========================================= Files 278 278 Lines 9823 9823 Branches 1227 1227 ========================================= Hits 5696 5696 Misses 3461 3461 Partials 666 666 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.