emeraldpay / emerald-wallet

Emerald Wallet
https://emerald.cash
Apache License 2.0
211 stars 102 forks source link

Setup Wallet : Choose Key Source Screen #1362

Open scco opened 8 months ago

scco commented 8 months ago
Bildschirmfoto 2023-12-27 um 04 19 17
  1. There is no hover effect for the options, so this feels a bit hard to understand what option i do select. So add a hover effect ( same to all other places where you select this type of "card" . this could be probably just a combination of change text to darkest color + cursor-pointer.

As you have to Choose one of the options ( Ledger, new seed, import ...), the bottom NEXT button is missleading and should be removed for that screen.

  1. Import existing Raw Private Key should be just : Import Private Key. There is now "raw" keys. difference between private key from json and private key is the format.

  2. I am unsure what is a "Ethereum JSON File" - you should add a source from what this file might come ? My Ether Wallet ? Official Ethereum Wallet ?

  3. Create from Ledger Nano
    Is not a "create" right ? This is a import of already existing addresses ? this is confusing for users , as they might expect to IMPORT their addresses from a ledger then ?! OR is thistruly a "create" by using what ever a secret from ledger to create a key source ? should be more precise whats going on with that option for users.