search

emeraldpay / hashicon

Generates a beautiful representation of any hash.
Apache License 2.0
191 stars 22 forks source link

Doesn't work in MS Edge or IE11 #28

Open careyestes opened 5 years ago

careyestes commented 5 years ago

Load up https://etcdevteam.github.io/hashicon/examples/ in Edge or IE and you will see it doesnt load the icons. Ive implemented it using React and get a few js errors in the console.

Both the hashicon demo site and my localhost get this: image

Will support for Edge and IE be added?

oori commented 5 years ago

Yes. The current code is written in modern javascript (ES6), we need to transpile for older browsers (I'm surprised IE Edge doesn't handle it..).
TODO: Babel (as rollup plugin) will solve this.

cwbutler commented 5 years ago

@oori, I see that babel is commented out in the rollup config file. Is this intentional? Will uncommenting the plugin fix?

oori commented 5 years ago

Nope.. Using "rollup-plugin-babel" is the start, but requires more. Lack of time and need pushes this down on my TODO list, but I'll try to do it soon. PR welcome.