Don't use text-encoding package (certainly not in browsers)

emeraldpay / hashicon

Generates a beautiful representation of any hash.

Apache License 2.0

191 stars 22 forks source link

Don't use text-encoding package (certainly not in browsers) #34

Closed sachaw closed 2 years ago

sachaw commented 2 years ago

I love this package, however I am using this in a very space constrained application, and the inclusion of the text-encoding package adds 615kb to my uncompressed bundle size (single largest dep by far). It's also deprecated.

I'd be happy to help get this working.

oori commented 2 years ago

@splix Why was TextEncoder added? https://github.com/emeraldpay/hashicon/commit/e386fb3da363c8b0ed9295eae251f62a8e995e31

splix commented 2 years ago

hm, I think it was part of something different, but ended up committing it. I don't think it's used.

@sachaw can you try to remove the dependency and see if that works for you? If yes, I'd appreciate a pull request.

splix commented 2 years ago

@sachaw published to NPM as v0.5.2