search

emergencyindex / emergencyindex.com

AN ANNUAL DOCUMENT OF PERFORMANCE PRACTICE
http://emergencyindex.com
GNU General Public License v3.0
2 stars 2 forks source link

Project map update script #48

Closed whatcoloris closed 4 years ago

whatcoloris commented 4 years ago

Combed through 2011 and 2012 already with this script

how to use!

cd emergencyindex.com/utilz
ruby map_update.rb -g ../_projects/2012 -c True

-g flag indicates geocoding -c flag causes each project's coordinates to be cached locally

edwardsharp commented 4 years ago

ohey, cool! a few thoughtz:

i kindof forgot that we just published the list of 2018 contributors directly to this emergencyindex.com repo and not a submodule. your commit contains both the 2018 contributors index html file (which is already in the repo) as well as the submodule change in .gitmodules. we should pick one or the other and preferably the submodule.

however, i don't think these issues with the 2018 contributors index and submodules have anything to do with this PR about a script to encode geo coordinates in the project data files. so i'd like to see those changes removed before merging this PR.

also, it seems like you copied the scrape_indesign.rb script to map_update.rb and added a geocode_projects function. the result is a lot of duplicated code which seems confusing. i'd say the two reasonable options would be to either 1) just add the geocode_projects definition to scrape_indesign.rb or maybe even preferably yank all the stuff that's not related to geocode_projects from the map_update.rb script?

edwardsharp commented 4 years ago

...also, i guess i don't understand the -c flag; i mean, redis is neat but how is this useful? what's the intention for using redis?

whatcoloris commented 4 years ago

...also, i guess i don't understand the -c flag; i mean, redis is neat but how is this useful? what's the intention for using redis?

whatcoloris commented 4 years ago

Agreed on all accounts, will make these changes.

Redis is great for not making several API calls! That's why the -c flag is useful, also a lot of people are performing at similar places so...

edwardsharp commented 4 years ago

@whatcoloris so this PR has a change to .gitmodules adding the 2018 contributors, which will be handled over at #51. so you won't want to include changes for that here. i'd imagine this PR to only contain the utilz/map_update.rb file...

edwardsharp commented 4 years ago

@whatcoloris i'm closing this PR because i'm trying to delete the master branch.