Closed whatcoloris closed 5 years ago
i think that might be there because of the annoying thing on iPhone where the bottom 64px of the screen is sometimes the safari nav and sometimes not.
look forward to seeing what you come up with
On Wed, Mar 20, 2019 at 10:18 AM whatcoloris notifications@github.com wrote:
if we remove position: unset from the media query in nav.scss then the social-nav doesn't free float anymore which i think is kind of nice, is that there because of the "dance" for the table of contents (for contributors, terms, volume pages, etc)?
if that's the case i propose we just yank it whenever the sidebar expands into a toc, will be working on js to make the blob do that today!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/emergencyindex/emergencyindex.com/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AAiNuEIS6dUpd0DzPfsnGPzuZIdctrj3ks5vYkMigaJpZM4b_aaW .
my proposed fix would be get rid of it when the table of contents are down and when there's safari detected bump it up???? would that work? i never use safari i'm realizing...
this is also fine honestly. we've got bigger fish to fry!
if we remove position: unset from the media query in nav.scss then the social-nav doesn't free float anymore which i think is kind of nice, is that there because of the "dance" for the table of contents (for contributors, terms, volume pages, etc)?
if that's the case i propose we just yank it whenever the sidebar expands into a toc, will be working on js to make the blob do that today!