Closed lizzthabet closed 3 years ago
gonna just go ahead and merge this!
just updating y'all - this has been rolled out to the play store!
Hi Ross, Sorry about the delay in getting back to you - it's been a busy couple weeks for me! Thanks for merging for us.
I'll keep an eye out for issues future issues!
@jaqarrick and I made progress on issue #35. This PR adds interactive icons for website and text for each hotline entry that has that information available. It doesn't include any work related to tags (which are also mentioned in #35).
constants/PhoneNumbers
to store text information in an object withcontent
andnumber
properties, instead of a stringIconGroup
component that's responsible for rendering phone, text, and website icons that link to the corresponding urlView from web app:![Screen Shot 2020-12-15 at 4 48 33 PM](https://user-images.githubusercontent.com/23283986/102278683-38c24780-3ef8-11eb-867c-ee62c93d776c.png)
View from iOS simulator:![Screen Shot 2020-12-15 at 4 48 00 PM](https://user-images.githubusercontent.com/23283986/102278640-23e5b400-3ef8-11eb-9292-5e146122b3f6.png)
View from messages app on desktop after clicking sms link from web app:![Screen Shot 2020-12-15 at 4 49 30 PM](https://user-images.githubusercontent.com/23283986/102278721-4aa3ea80-3ef8-11eb-93a9-7e832d330a01.png)
We tested in browser and Expo Android app without any issues. The iOS simulator had a couple bugs: phone number links (whose implementation didn't change in our code) threw an error; and sms texting links opened up in the messages app with the appropriate content, but not the appropriate phone number. After googling for a bit, our best guess is that both of these issues are due to limitations in the iOS simulator and not with the
tel
orsms
links.This is our first time contributing to this project, so feel free to let us know if there are any code style or implementation details that can be approved or better aligned with existing patterns!
A couple additional questions: