Kobo iframe too large

[iltempe]

Priorità: alta

Richiesta

Emmbedding IFRAME of KOBO in greeek branch we have too many "empty spaces" ;-) https://gr.covid19people.help/anebase-pliroforia/%CE%B4%CF%89%CF%81%CE%B5%CE%AC-%CE%B1%CE%B3%CE%B1%CE%B8%CF%8E%CE%BD-%CF%85%CF%80%CE%B7%CF%81%CE%B5%CF%83%CE%B9%CF%8E%CE%BD In Italian version everything is good. WHy?

Come si riproduce il bug

Risolto?

• [ ] Ho verificato che il problema è stato risolto

[dchatzoglou]

The same problem is with Portugal's webforms.

[avivace]

@olistik Can you help us on this?

[olistik]

@avivace I'll do my best. 🙂 When I load the link I get an Nginx error page. Is there another working link available?

[avivace]

It should be back online

[olistik]

@avivace Unfortunately I still see an error:

link

Also:

link

Is this expected? Do you think it's related? 🤔

[avivace]

@dchatzoglou Any idea about this?

[iltempe]

now it's seems work.

[dchatzoglou]

No idea about the error and I havent touched the forms. I have only added the hyperlink a couple of minutes ago. Sorry, i have to link the issues witn an email notification to respond quickly.

[dchatzoglou]

The forms are back and all the links are functional. The lots of space below remains.

[iltempe]

@olistik but for italian version how we hade removed blank space?

[avivace]

@olistik can you help us on this?

[olistik]

@iltempe @avivace Sorry for the delay. We arbitrarily set the height to a value so that forms could fit vertically.

[olistik]

@avivace @iltempe Could you provide a working link showing the undesired behavior?

[olistik]

You can see in this example:

https://github.com/emergenzeHack/covid19italia/blob/master/_segnalazioni/chiedi-aiuto.html#L8

That we're using a CSS class to set the height of the iframe: iframe-embed--v200. This class is defined here: https://github.com/emergenzeHack/covid19italia/blob/6e47f1713dd56237db6f58cf85850f5c1439b6b5/css/responsive_iframes.css#L8

This class has worked fine so far but if we need to adjust a specific iframe, we can create new classes and put them in the required context.

[iltempe]

https://www.covid19italia.help/segnala/chiedi-aiuto/

[olistik]

@iltempe @avivace Please take a look at #526 to verify if the proposed solution solves the issues. I created a CSS class for each page so that every iframe fits nicely.

[iltempe]

@olistik is possible to pull request also on gr_branch and pt_branch? Thanks

[dchatzoglou]

Excellent, it works for the gr branch forms. thank you all

[avivace]

Thank you @olistik !

[iltempe]

i close. thanks @olistik !