emericg / OpenSubtitlesDownload

Automatically find and download the right subtitles for your favorite videos!
https://emeric.io/OpenSubtitlesDownload
GNU General Public License v3.0
595 stars 66 forks source link

cannot find an existing "tur" subtitle #12

Closed Sadi58 closed 10 years ago

Sadi58 commented 10 years ago

I've just started using this. I was looking for Turkish subtitles for Woody Allen's 1976 movie "The Front" but this nice Python script says none although I know there is at least one that matches: http://www.subtitleseeker.com/0074554/The+Front/Subtitles/Turkish/

TaylanTatli commented 10 years ago

This script not using subtitleseeker. did you edit OpenSubtitlesDownload.py for Turkish? Change SubLanguageIDs = ['eng'] to SubLanguageIDs = ['tur'] and it will work. I'm using right now. :)

Sadi58 commented 10 years ago

Thanks. I meant Subtitleseeker found Turkish subtitles for this on opensubtitles.org although this could not find any. I'm using it as a Nautilus Script, and when simply insert 'tur' before 'eng', it can only find the English subtitles for this. If I replace "eng" with "tur" it simply says "No synchronized subtitles found for this video" although the file name found by Subtitleseeker on opensubtitles.org is "The.Front.1976.1CD.23.976-FPS.SUB" i.e. same frame rate.

TaylanTatli commented 10 years ago

Can you check with mine. Because mine is working. https://drive.google.com/file/d/0B0_Io4CEVkImWGtndnpIXzdpMms/edit?usp=sharing

Sadi58 commented 10 years ago

Thanks. They're exactly the same. You've only changed SubLanguageIDs from 'eng' to 'tur' and so did I. Very strange :-)

emericg commented 10 years ago

Hi! Sorry for the late answer. You are right there is a subtitles for the movie you want: http://www.opensubtitles.org/fr/search/sublanguageid-tur/idmovie-36950 (because as stated by Taylan we do use opensubtitles and not subtitle seeker). But:

As stated in the software description, this script try to match your file with a "known" video file. This way you get a synchronized subtitles, known to work with your particular file. This process is only possible if one person had previously provided a correspondace between the same file you are using and a subtitles. You can do that by manually uploading an hash or watch a movie with a video player that automatically upload file hashes.

This works great on popular file. It's a bit "all or nothing": you have a working synchronized subtitles or you don't get anything ^^ (and you have to search for a subtitles manually).

In your case, the video file you are using is probably "unknown" by opensubtitles.org, so no result with the script, and that is why you get the message "No synchronized subtitles found for this video".

I could develop a feature where the subtitles would be search by name and not by file hash, but this would be very prone to errors and I'll probably get a lot of complains then because the subtitles wouldn't match the video.

Sadi58 commented 10 years ago

Thanks. All you say makes sense - sync and hash, etc. But I don't understand (I don't know much about this file matching process), if this script can identify this movie file (The Front by Woody Allen) and can find the English subtitles alright, how come it cannot see the Turkish subtitles at the same site (www.opensubtitles.org) when I use the language setting as 'tur,eng' ? Does it require another hash for Turkish subtitles of the same movie?

TaylanTatli commented 10 years ago

It's working with eng and tur. Look my screenshot. Maybe it's about the movie, Turkish subtitle is not added for this movie. 2014-04-05 00 31 10 ekran grnts

Sadi58 commented 10 years ago

Thank you very much for your efforts to help me, but I'm sorry that we're not making much progress. Can you please try searching for English OR Turkish Subtitles for Woody Allen's movie "The Front" and comment about it? Subtitleseeker merely helped me find it on www.opensubtitles.org which is here: http://www.opensubtitles.org/tr/subtitles/5288152/the-front-tr My question is; why can't this good script find it? Is it because of a hash problem or what?

emericg commented 10 years ago

@TaylanTatli Yes the software works in turkish, it just doesn't find subtitles for every video files.

@Sadi58 To find a synchronized subtitles, you'll need a subtitles that has been tagged with the hash for your exact file. So the movie may already be known by opensubtitles.org, it may have even a subtitles, but there is no hash linking the two. Subtitles are always made to accomodate a particular "version" of a movie. The framerate and synchronisation must be perfect for you to enjoy, that is why this relation between a movie and a subtitles is not made automatically, but "manually" by uploading file hash.

I hope it answer your question.

Sadi58 commented 10 years ago

@emericg Thanks for the final clarification. Now I understand the cause. It seems the person who uploaded the Turkish subtitles didn't properly "match" it with the movie concerned.

emericg commented 10 years ago

Yes that's it. This "matching" or "tagging" process is not mandatory when you add a new subtitles through the opensubtitles.org website. It's just a way to helps software like this one to find subtitles in a fully automated way.

Some video player software can automatically upload a new subtitles and its corresponding file hash (or just the hash if the subtitles already exist), if and only if you watched more than 75% of the video with the subtitles enabled. That's a neat feature!

If that's ok with you I'll close this issue.

Sadi58 commented 10 years ago

Sure. Thank you very much.