search

emericg / OpenSubtitlesDownload

Automatically find and download the right subtitles for your favorite videos!
https://emeric.io/OpenSubtitlesDownload
GNU General Public License v3.0
581 stars 63 forks source link

manual search downloading incorrect subtitle if there is only one option #33

Closed tmottabr closed 6 years ago

tmottabr commented 6 years ago

i use OpenSubtitlesDownload in cli mode only.

If i have search set to manual, fallback to search by name on and there is only one subtitle available it will be download regardless if it is the correct one or not.

If i have manual search set i believe the fallback should ask me if i want to download that subtitle even if there is only one as I want to review if it is the correct sub for my file first.

emericg commented 6 years ago

Hi, Automatically downloading the 'only' subtitles available is the intended behavior indeed. IIRC it was an user request too ^^ Now I understand your issue, it's not hard to fix, but I'm not sure if I should stop doing that in CLI mode only, or add another mode like 'full manual' or something... If think the first solution might be best fitted?!

emericg commented 6 years ago

Also, it will only automatically download single subitles with an hash match. So if the subtitles is indeed incorrect, then it's because it has been incorrectly uploaded on opensubtitles.org.

emericg commented 6 years ago

OK I added a new 'default' selection mode, that you can override with either manual or auto mode.