search

emericg / OpenSubtitlesDownload

Automatically find and download the right subtitles for your favorite videos!
https://emeric.io/OpenSubtitlesDownload
GNU General Public License v3.0
607 stars 66 forks source link

OpenSubtitlesDownload not working for some subtitles, even though they exists. #94

Closed wantedda443 closed 10 months ago

wantedda443 commented 1 year ago

Hi emericg

Thank you for a wonderful tool.

I have one problem, OpenSubtitlesDownload can't find subtitles for some movies, even though a search on Opensubtitles.org easily finds them. One example: The.Outfit.2022.1080p.AMZN.WEB-DL.DDP5.1.H.264-EVO.mkv

I've tried with hash search, filename search and both (then & and) but I get this output: >> No subtitles found for this video

Most subtitles the tools finds no problem.

I'm running on Ubuntu 20.04 and the command I use is: OpenSubtitles.py --cli --auto filename

lwouis commented 1 year ago

This project is using the deprecated XML-RPC API from OpenSubtitles. According to the OpenSubtitle project:

any API running on OpenSubtitles.org is deprecated and not possible to register new user agents anymore, we plan to turn off OpenSubtitles.org API by the end of 2023. Please use new, stable ready-to-use ​OpenSubtitles.com REST API instead.

Here is the link to the new API. I tested the new API, and it returns results where the old API doesn't. It's likely that the old API is abandonned, and doesn't tap into the most recent DB, or that it's implementation is inferior when it comes to matching on file names using the query param.

emericg commented 10 months ago

The new API is now implemented in the script, so I'll close this issue. Please reopen the issue if you have troubles with the new version as well.

emericg commented 10 months ago

And by the way, I can confirm that the "search by filename" does find more results now. Not sure that it's the case with the "search by hash" but as @lwouis mentioned, it's possible.