emersion / ganbo

A WebExtension to export cookies into a cookies.txt file
MIT License
13 stars 2 forks source link

Add initial support for First Party Isolation #3

Closed cenodis closed 4 years ago

cenodis commented 4 years ago

This PR addresses issue #1.

As I have stated in this issue this is not a perfect fix but it makes the extension usable for all websites which only use First Party Cookies for authentication. Third Party login systems will not work with FPI enabled but this is an intended browser limitation.

Some notes on this PR:

What still doesn't work:

I would suggest closing #1 as this extension now supports FPI in its current state and opening a new issue to track the more complicated process of extracting the FP-Domain. Additionally a separate issue to track the proper handling of third party cookies would be useful as this is largely independent of FPI.

I have tested this on Firefox 70.0. without FPI: my standard browser profile with FPI: a new temporary profile with privacy.firstparty.isolate set to true.

martinetd commented 4 years ago

New permission requests are scary (looked here after being prompted).

I don't think there's a way to describe permission changes when prompted on update (likely no custom text displayable) but some small text on the addons.mozilla.org page as to why permission x or y is needed might be good?

Thanks anyhow :D

emersion commented 4 years ago

Yeah, I haven't found anything like that unfortunately. I added a hint to the release notes.