search

emersion / go-imap

📥 An IMAP library for clients and servers
MIT License
2.07k stars 292 forks source link

Added MYRIGHTS and SETACL support #591

Closed opsxolc closed 4 months ago

emersion commented 7 months ago

This is part of the IMAP4 ACL extension.

emersion commented 7 months ago

It seems like a vendor/ dir was committed?

emersion commented 7 months ago

Also I'd prefer to avoid the testify dependency if possble…

emersion commented 7 months ago

Sorry, I keep getting more comments for new functionality...

I would suggest trying to upstream your patches step by step if you want me to merge stuff more quickly. That is, stop adding more features and functions, focus on addressing the review comments. But if you are fine with getting continuous feedback for new ACL functions, that's fine by me as well. I don't want you to be frustrated because of the feedback, is all.

I can also help addressing the review comments if you grow tired of it.

opsxolc commented 6 months ago

Hey! I'm drowning in work right now, but I'll be back with fixes as soon as I can. I really want to contribute to this project)

emersion commented 6 months ago

No worries, take your time :)

opsxolc commented 5 months ago

So builds.sr.ht failed due to the issue with ACL extension support as I mentioned in a thread above

emersion commented 4 months ago

The error message from CI is:

    acl_test.go:74: create MyFolder.Child error: imap: NO [CANNOT] Character not allowed in mailbox name: '.' (0.001 + 0.000 secs).

By default Dovecot uses . for mailbox delimiters. a3d367456797a4cf1a9c853ba0e7d75dff67f069 changes it to / (to align it with imapmemserver).

emersion commented 4 months ago

The client parts have been merged in #618, still missing the server part from this PR.